Skip to content

fix: ignore deferred panzoom transforms after the preview image is gone - #4216

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/preview-panzoom-unmount
Nov 5, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/preview-panzoom-unmount

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Closing or leaving an image in the preview right after it appears no longer throws a setStyle error, because a late zoom/pan update from the removed image is now ignored.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: a deferred setTransform after unmount doesn't throw
  • test case 2: browser: closing or switching right as the image appears (desktop and Pixel 7), zoom, rotate, reset and keyboard navigation unchanged

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@tammi-23 tammi-23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@AlexAndBear
AlexAndBear merged commit dc4df01 into main Nov 5, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/preview-panzoom-unmount branch November 5, 2026 00:42
@openclouders openclouders mentioned this pull request Nov 5, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preview logs a setStyle error when an image is left right after it appears

2 participants